[chrome_print] Connect to the Browser websocket URL instead of the Page one #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e goal is to avoid check fails like https://travis-ci.org/rstudio/pagedown/builds/628515805#L1241
|
Sorry for the delay. Yes, this definitely fixes it for me. Thanks! |
|
@gershomtripp Great news! Thanks for your test! It will be merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #158. I'm unable to reproduce the bug declared in #158 but I think that controlling the target (i.e. tab or page) creation could resolve it.
The strategy is the following:
sessionIdsessionIdin all the commands@gershomtripp Please, could you test this PR and tell me whether it solves the problem?
You need first to install the PR version with: