Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serve_site(): Add support for bundle exec jekyll #695

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

pat-s
Copy link
Contributor

@pat-s pat-s commented Apr 12, 2022

This PR adds support for bundle exec jekyll for serve_site(). The only change the user needs to do is to set options(blogdown.generator = "bundler_jekyll").

fixes #694

  • The actual command issues is bundle which is coming from the bundler GEM (note the additional 'r').
  • Not bound to any naming, feel free to adjust and possible simplify/reduce the ifelse statements
  • Tested on a jekyll site which only runs using bundle exec jekyll
  • Requires bundle to be found on the path (gem install bundler)

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just simplified the implementation. What do you think? Thanks!

@pat-s
Copy link
Contributor Author

pat-s commented Apr 12, 2022

Awesome! I knew there must be an easier way than touching so many parts but I was happy in the first place when I got everything working to move forward.

Thanks for the quick patch!

@yihui yihui merged commit fa4e77f into rstudio:main Apr 12, 2022
yihui added a commit that referenced this pull request Apr 13, 2022
Co-authored-by: Yihui Xie <xie@yihui.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Add support for bundle exec jekyll
2 participants