Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom resolver support #1941

Merged
merged 1 commit into from
Jul 9, 2018
Merged

custom resolver support #1941

merged 1 commit into from
Jul 9, 2018

Conversation

ahorek
Copy link

@ahorek ahorek commented Jan 3, 2018

fixes #1841

@JonRowe
Copy link
Member

JonRowe commented Jan 5, 2018

Thanks for trying to tackle this @ahorek could you please add a spec that shows what this fixes.

@ahorek ahorek changed the title WIP: custom resolver support custom resolver support Jan 6, 2018
@JonRowe
Copy link
Member

JonRowe commented Jan 7, 2018

Thanks, @samphippen are you happy to merge this without getting master green first? Or should I hold off until master is all green, get this rebased and double check it passes?

@ahorek ahorek force-pushed the fix_custom_resolver branch from 494f3d6 to 0636165 Compare February 6, 2018 22:43
@ahorek ahorek force-pushed the fix_custom_resolver branch from 0636165 to a3731a6 Compare April 4, 2018 21:14
@hogelog
Copy link

hogelog commented Jul 6, 2018

What status this PR?
I hope that this fix will be merged.

@benoittgt
Copy link
Member

I think commits could be squashed. Otherwise LGTM

@ahorek ahorek force-pushed the fix_custom_resolver branch from a3731a6 to 9816cd3 Compare July 9, 2018 08:10
@ahorek
Copy link
Author

ahorek commented Jul 9, 2018

done

@JonRowe JonRowe merged commit 8bd9f60 into rspec:master Jul 9, 2018
JonRowe added a commit that referenced this pull request Jul 9, 2018
@JonRowe
Changelog for ##1941
de6d35a
sebjacobs pushed a commit to futurelearn/rspec-rails that referenced this pull request Mar 15, 2019
@JonRowe @sebjacobs
Changelog for #rspec#1941
67c051e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoittgt benoittgt benoittgt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specs, using custom resolver for ActionView path, are failing
4 participants
@ahorek @JonRowe @hogelog @benoittgt