Fix empty template rendering for Rails 4.2.5.1 #1535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fables-tales
pushed a commit
that referenced
this pull request
Jan 26, 2016
fables-tales
pushed a commit
that referenced
this pull request
Jan 26, 2016
fables-tales
pushed a commit
that referenced
this pull request
Jan 26, 2016
fables-tales
pushed a commit
that referenced
this pull request
Jan 26, 2016
550f1b3 to
b498a38
Compare
| controller.extend(EmptyTemplates) | ||
| end | ||
| end | ||
|
|
||
| after do | ||
| unless render_views? | ||
| controller.class.view_paths = @_empty_view_path_set_delegator.original_path_set | ||
| controller.class.view_paths = @_original_path_set |
There was a problem hiding this comment.
Rubocop on Travis wants:
controller.class.view_paths = @_original_path_set unless render_views?
There was a problem hiding this comment.
Hi! We've actually merged a travis passing-fix in 3.4.1, this fix is a forward-port of that. And I'll fix that tomorrow.
Closes rspec#1532. Refactor the template rendering overrides in controller specs to be more compatible with the Action View public api. Previously `EmptyTemplatePathSetDecorator` overrode the `find_all` method to wrap a path set. However `ActionView::PathSet` is not public api so instead create a subclass of `ActionView::FileSystemResolver` to return an empty template and treat `view_paths` as an array of string-like objects.
b498a38 to
80637fc
Compare
fables-tales
pushed a commit
that referenced
this pull request
Jan 27, 2016
Fix empty template rendering for Rails 4.2.5.1
|
Thank you @pixeltrix @samphippen @fcheung etc. for fixing this issue. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1532.
Refactor the template rendering overrides in controller specs to be more compatible with the Action View public api. Previously
EmptyTemplatePathSetDecoratoroverrode thefind_allmethod to wrap a path set. HoweverActionView::PathSetis not public api so instead create a subclass ofActionView::FileSystemResolverto return an empty template and treatview_pathsas an array of string-like objects.