This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Prevent deprecation warning from expect(FileTest).to exist(x)
#1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirj
approved these changes
Sep 12, 2022
lib/rspec/matchers/built_in/exist.rb
Outdated
| @@ -81,7 +81,7 @@ def predicates | |||
| end | |||
|
|
|||
| def deprecated(predicate, actual) | |||
| predicate == :exists? && File == actual | |||
| predicate == :exists? && [File, FileTest].include?(actual) | |||
There was a problem hiding this comment.
Cosmetic: File == actual || FileTest == actual?
``` FileTest.exists? is a deprecated name, use FileTest.exist? instead ```
1d4c923 to
e176f25
Compare
JonRowe
added a commit
that referenced
this pull request
Sep 12, 2022
JonRowe
added a commit
that referenced
this pull request
Sep 12, 2022
Prevent deprecation warning from `expect(FileTest).to exist(x)`
JonRowe
added a commit
that referenced
this pull request
Sep 12, 2022
JonRowe
added a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
expect(FileTest).to exist(x)also outputs deprecation warnings in the same way asexpect(File).to exist(x)before #954.I confirmed that this warning is displayed on Ruby 2.7.6 and Ruby 3.1.2.
So it would be nice that we also support
FileTestas well asFile. It won't be used that much, but it's not a big change and it would be better to support it.