feat: add rsdoctor UT test #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LingyuCoder
reviewed
Jan 22, 2025
tests/rsdoctor.ts
Outdated
| @@ -7,10 +7,8 @@ export async function test(options: RunOptions) { | |||
| repo: 'web-infra-dev/rsdoctor', | |||
| branch: process.env.RSDOCTOR ?? 'main', | |||
| beforeTest: async () => { | |||
| cd('./e2e') | |||
There was a problem hiding this comment.
need to remove the imported cd
There was a problem hiding this comment.
done~ there also have some ci error because of the version of ubuntu.
|
@jerrykingxyz There are many errors in this ci, and rsdoctor ci is still the problem of Ubuntu 24. Do you want to lock the Ubuntu version here? |
Sure, the rspack repo is locked to Ubuntu version 22.04, and you can use the same configuration in this repo. https://github.com/web-infra-dev/rspack/blob/main/.github/workflows/ecosystem-ci.yml#L131 |
80c8628 to
e692d13
Compare
chenjiahan
approved these changes
Jan 24, 2025
9aoy
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add rsdoctor UT test