Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support tailwindcss v3.1.x and v3.2.y #21

Merged
merged 12 commits into from
Dec 28, 2024
Merged

feat: support tailwindcss v3.1.x and v3.2.y #21

merged 12 commits into from
Dec 28, 2024

Conversation

colinaaa
Copy link
Collaborator

@colinaaa colinaaa commented Nov 23, 2024 •
edited
Loading

Summary

Support Tailwind CSS v3.1 and Tailwind CSS v3.2.

Details

Since Tailwind CSS support using ESM configuration in V3.3, we need to use CJS configuration before that.

As mentioned in #7 (comment), we use readFile + require.resolve to get the version of tailwindcss/package.json.

  • If satisfies(version, ^3.3.0), we will generate ESM configuration to support both ESM and CJS.
  • Else, we generate CJS configuration.

Test plan

We setup two new entries in the testing matrix

  • tailwindcss v3.1.0 with Ubuntu
  • tailwindcss v3.1.0 with Windows

As you can see, the test is failing at 0e05c6a.

And after the fix is landed in e783415, the test for old tailwindcss is passing.

Related links

close: #18

@colinaaa
ci: add tests for different tailwindcss version

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
a6ee22c
@colinaaa
ci: add || echo 'Success'
7d0e927 
Avoid `rslib build` failed due to tailwindcss types not correct.
@colinaaa
test: skip when not supporting ESM
0e05c6a
@colinaaa colinaaa changed the title feat: support tailwindcss before v3.3.0 feat: support tailwindcss v3.1.x and v3.2.y Nov 23, 2024
@colinaaa colinaaa requested a review from chenjiahan November 23, 2024 18:00
@colinaaa colinaaa marked this pull request as ready for review November 23, 2024 18:00
@colinaaa colinaaa mentioned this pull request Nov 23, 2024
Merged
@colinaaa colinaaa requested a review from luhc228 November 26, 2024 03:41
chenjiahan
chenjiahan reviewed Nov 26, 2024
View reviewed changes
chenjiahan
chenjiahan approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colinaaa colinaaa added this pull request to the merge queue Dec 28, 2024
Merged via the queue into main with commit 34eff9d Dec 28, 2024
4 checks passed
@colinaaa colinaaa deleted the colin/cjs-tailwind branch December 28, 2024 07:46
github-merge-queue bot pushed a commit that referenced this pull request Dec 28, 2024
@colinaaa
fix!: change peer of tailwindcss to ^3.1.0 (#23)
6807507 
>[!WARNING]
>
> Please note that this is a **BREAKING CHANGE**.

As the test result of #21 shows that we does not support Tailwind CSS
v3.0.x. Since it does not have `config` option yet.

And v3.1.x and v3.2.y will be supported after #21 is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan

@luhc228 luhc228

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Error: [ERR_REQUIRE_ESM]: require() of ES Module /tmp/unit-v2h13040/tailwind.config.js
3 participants
@colinaaa @chenjiahan @luhc228