Added wrapSource and includeRuntime options #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +33,9 @@ exports.defaultCompilationOptions = { | |||
| outputFormatting: {indent_level: 2, beautify: true}, | |||
| detailedOutput: false, // if true, return {ast: <ast>, code: <code>} | |||
| strict: true, // adds '"use strict";' to the head of generated js code | |||
| raw: false // Do not wrap source and do not enable runtime | |||
| raw: false, // Disable keyword args that require the Move runtime. | |||
There was a problem hiding this comment.
Could you change this to say "Do not depend on or include the Move runtime library" instead?
There was a problem hiding this comment.
After the split, raw does not affect whether the runtime is included - that is controlled only by includeRuntime, so I'd go for just "Do not depend on the Move runtime library".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This treats issue #8. It separates the 3 different effects of raw mode into separate options:
raw: Don't rely on the runtime for keyword arg treatment (can be deprecated).wrapSource: Wrap the produced source with a closure.includeRuntime: Import the Move runtime functions into the scope of the compiled code.This covers all my REPL needs, and does not change the default behaviour at all.