This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When the users resets/change phone, all data is migrated to the new phone, when for security reasons it shouldn't. The private data should 'live' only on the scope of the current device.
Tech description
rWallet uses lib rn-secure-storage for saving data in the device, from their docs they have some ways to set how to save data.
To fix it lets change to:
WHEN_UNLOCKED_THIS_DEVICE_ONLY
: The data in the keychain item can be accessed only while the device is unlocked by the user. Items with this attribute do not migrate to a new device.What do we store?
How to test it