This repository has been archived by the owner on Oct 12, 2023. It is now read-only.
Disable Back button for biometrics and passcode modal. #654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hardware back button functionality to close the Fingerprint and Passcode modal.
With other parts of the app, such as the Dapp Browser, disabling the back button can be done with the BackHandler. However, since this a modal, and is visible,
BackHandler
events will not fire. See the first warning in the BackHandler link above. As such, the onRequestClose event will fire when the Back Button is pressed.In the previous code, if the user clicked the back button, it fired the
onRequestClose
event, which in the end, would hide the modal's contents, closing the modal. See removed lines 127 and 132.The biometrics component already had the functionality to fallback to a passcode. Therefore, the required function
onRequestClose
should always returnfalse
.Tested on:
How to test:
iOS Note: I am unable to test iOS. Please make sure you can log in with existing login options.