Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'fill' property #2

Merged
merged 4 commits into from
Jun 24, 2016
Merged

Add 'fill' property #2

merged 4 commits into from
Jun 24, 2016

Conversation

olegafx
Copy link
Contributor

@olegafx olegafx commented Jun 24, 2016

SVG icons uses fill property to set colors

@rsanchez
Copy link
Owner

Thanks. Can you add a test to test/test.js?

    it('should extract fill.', function (done) {
        test(
            'svg { fill: red; } p { display: block; }',
            ['red'],
            {},
            done
        );
    });

@olegafx
Copy link
Contributor Author

olegafx commented Jun 24, 2016

Done. But now build check failed. Is it ok?…

@@ -237,6 +237,15 @@ describe('postcss-colors-only', function () {
done
);
});

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olegafx This is the line causing the CI to fail.

test/test.js
  240:1  error  Trailing spaces not allowed  no-trailing-spaces

Making this line a blank line instead of 4 spaces should fix it. Do that and I'll merge. :D

@rsanchez rsanchez merged commit 8b05700 into rsanchez:master Jun 24, 2016
@rsanchez
Copy link
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants