uncertainty scaling update #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjlane
added a commit
that referenced
this pull request
Oct 25, 2024
* variance weighting bugfix need test * new test, not the strongest, but ok
tjlane
added a commit
that referenced
this pull request
Oct 27, 2024
* initialize diff script * add scaling * initial tv denoise script draft * print result * how to unify - may be busted * minor changes * iterative tv * work * getting better * standardize on column, not label * focus on one script for now * homogenize on weight not lambda (#42) * uncertainty scaling update (#41) * variance weighting bugfix need test * new test, not the strongest, but ok * TvDenoise metadata csv writer * lint * resolve a few todo * common unit tests * unit tests * prep for functional test * fix find replace mishap * tag as TO OPTIMIZE * squash last rename error * squash magic numbers and consistent formatting * test data staging * bughunter * test skeleton in place * better read write tv result * tv result improvements * testing almost there * just various * docstrings * type safety * lint * use golden optimization for TV weight (#45) * golden optimizer * test precision * @alisiafadini feedback * lint * decrease random test tolerance * fix typo --------- Co-authored-by: Alisia Fadini <alisia.fadini15@imperial.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable scaling of two maps with uncertainty weighting when only one map has uncertainties. This is common; we often scale an observed map to a computed one.
I also found and fixed a bug, and simplified the code slightly.