-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
map object and major refactor #24
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 93.33% 96.58% +3.25%
==========================================
Files 8 9 +1
Lines 345 498 +153
==========================================
+ Hits 322 481 +159
+ Misses 23 17 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Need a scaling function that handles maps.
This PR implements a new
meteor.rsmap.Map
object, which is a subclass ofrs.DataSet
that strictly holds 3 columns of:This enables a much cleaner implementation of METEOR.
There are some challenges around ensuring that the child class of
rs.DataSet
behaves properly, and testing this is WIP.