Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map object and major refactor #24

Merged
merged 51 commits into from
Oct 17, 2024
Merged

map object and major refactor #24

merged 51 commits into from
Oct 17, 2024

Conversation

tjlane
Copy link
Collaborator

@tjlane tjlane commented Oct 15, 2024

This PR implements a new meteor.rsmap.Map object, which is a subclass of rs.DataSet that strictly holds 3 columns of:

  • amplitudes
  • phases
  • uncertainties

This enables a much cleaner implementation of METEOR.

There are some challenges around ensuring that the child class of rs.DataSet behaves properly, and testing this is WIP.

@tjlane tjlane mentioned this pull request Oct 15, 2024
@tjlane tjlane changed the title map object map object and major refactor Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (b8c51b8) to head (05ad10b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   93.33%   96.58%   +3.25%     
==========================================
  Files           8        9       +1     
  Lines         345      498     +153     
==========================================
+ Hits          322      481     +159     
+ Misses         23       17       -6     
Flag Coverage Δ
unittests 96.58% <100.00%> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjlane tjlane marked this pull request as ready for review October 16, 2024 17:03
@tjlane tjlane self-assigned this Oct 16, 2024
@tjlane tjlane requested a review from alisiafadini October 16, 2024 17:03
Copy link
Collaborator

@alisiafadini alisiafadini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Need a scaling function that handles maps.

@tjlane tjlane merged commit 47dc49a into master Oct 17, 2024
5 checks passed
@tjlane tjlane deleted the tjlane/use-mapobj branch October 17, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants