Helpful error detection from sub-processes #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the program behavior when a subprocess (CCP4 or phenix process called from the command line) fails is very unhelpful. If verbose mode is off, the subprocess will fail silently. The main program will then error out with a
FileNotFoundError
that is not necessarily informative to a user. If verbose mode is on, the subprocess error message will be printed, but the latest error presented will still be the unhelpfulFileNotFoundError
.This PR wraps all calls to
subprocess.run()
in a helper function which