Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure animations don't continue playing when we've paused playback #417

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

eoghanmurray
Copy link
Contributor

Further work:
The animation state won't follow scrubbing/jumping of playback position, but I don't know any way of achieving that.

@Yuyz0112
Copy link
Member

LGTM.

And I think this is a try-my-best strategy right @eoghanmurray ? Because there may be some JS animation we could not pause. And basically we are out of control with the animation state.

@eoghanmurray
Copy link
Contributor Author

eoghanmurray commented Nov 18, 2020

Yes, it's just handles the a specific CSS animation that I noticed in a recording.

Any JS animations should be paused naturally as they are being rendered via mutations though right?
Maybe you are thinking of GIF animations?
If so ya that would be under 'further work' ☺️

For GIF: https://github.com/ctrl-freaks/freezeframe.js has a typescript implementation — and we'd have no control over frame position with that either (it jumps back to the start upon pause).

@Yuyz0112
Copy link
Member

Thanks!

@Yuyz0112 Yuyz0112 merged commit facd6cc into rrweb-io:master Nov 25, 2020
@YunFeng0817
Copy link
Member

@eoghanmurray In my application, I need the CSS transition finished after I paused play. Could we add an option for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants