Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrweb not capturing styling changes coming from material-ui #650

Closed
Equlnox opened this issue Aug 2, 2021 · 3 comments
Closed

rrweb not capturing styling changes coming from material-ui #650

Equlnox opened this issue Aug 2, 2021 · 3 comments

Comments

@Equlnox
Copy link
Contributor

Equlnox commented Aug 2, 2021

Code sandbox link - https://codesandbox.io/s/competent-cdn-ckn2h?file=/src/App.tsx:360-366

If you visit https://ckn2h.csb.app/#, the button click updates the color of box from red to blue.
Sessions recorded through rrweb don't have the color changing.

Here is a loom recording showing that the color doesn't change in rrweb replay -
https://www.loom.com/share/62b6685ea5bd49c2a1895571572c6ed6

@Yuyz0112
Copy link
Member

The reason is we do not observe CSSStyleDeclaration.setProperty and CSSStyleDeclaration.removeProperty.

Going to send a PR for fix.

@Equlnox
Copy link
Contributor Author

Equlnox commented Aug 17, 2021

Hey @Yuyz0112 .. any chance you were able to work on this?

Yuyz0112 added a commit that referenced this issue Aug 18, 2021
Yuyz0112 added a commit that referenced this issue Aug 18, 2021
@Yuyz0112
Copy link
Member

@Equlnox You can check #671 for the status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants