Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render Frame 0 #216

Closed
jwbrew opened this issue May 15, 2020 · 3 comments
Closed

Render Frame 0 #216

jwbrew opened this issue May 15, 2020 · 3 comments

Comments

@jwbrew
Copy link
Contributor

jwbrew commented May 15, 2020

When initalising a new Replayer, if play() is not called, there is just a blank screen with a cursor position available. Should it be possible to show the first frame of the recording?
@Yuyz0112
Copy link
Member

Good idea, going to add this

@Yuyz0112
Copy link
Member

Good idea, going to add this

@eoghanmurray
Copy link
Contributor

One problem with this is that you don't get a chance to attach a handler for the fullsnapshot-rebuilded event.

I see that there is special setTimeout treatment for the Resize event, but maybe that's for a different purpose?

eoghanmurray added a commit to statcounter/rrweb that referenced this issue Nov 11, 2020
@eoghanmurray
Allow to be chained directly after the constructor so that event hand…
9041099 
…ling for the first full snapshot can be added straight after constructor. See rrweb-io#216
eoghanmurray added a commit to statcounter/rrweb that referenced this issue Nov 11, 2020
@eoghanmurray
Allow .on to be chained directly after the constructor so that even…
47fb02e 
…t handling for the first full snapshot can be added straight after constructor. See rrweb-io#216
@eoghanmurray eoghanmurray mentioned this issue Nov 11, 2020
Merged
Yuyz0112 pushed a commit that referenced this issue Nov 15, 2020
@eoghanmurray
Allow .on to be chained directly after the constructor so that even…
5c9919e 
…t handling for the first full snapshot can be added straight after constructor. See #216 (#416)
eoghanmurray added a commit to statcounter/rrweb that referenced this issue Nov 23, 2020
@eoghanmurray
Allow to be chained directly after the constructor so that event hand…
a866777 
…ling for the first full snapshot can be added straight after constructor. See rrweb-io#216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eoghanmurray @Yuyz0112 @jwbrew