apply Justin's review suggestions

1. make Mirror's replace function act the same with the original one when there's no existed node to get replaced. 2. when replacing with the link/style elements, keep their existing attributes to prevent potential bugs
rrweb-io · Sep 29, 2022 · 8aefe2b · 8aefe2b
1 parent 10a750d
commit 8aefe2b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/rrdom/src/index.ts b/packages/rrdom/src/index.ts
@@ -393,8 +393,8 @@ export class Mirror implements IMirror<RRNode> {
     if (oldNode) {
       const meta = this.nodeMetaMap.get(oldNode);
       if (meta) this.nodeMetaMap.set(n, meta);
-      this.idNodeMap.set(id, n);
     }
+    this.idNodeMap.set(id, n);
   }
 
   reset() {

diff --git a/packages/rrweb/src/replay/index.ts b/packages/rrweb/src/replay/index.ts
@@ -1654,7 +1654,10 @@ export class Replayer {
                   const newSn = mirror.getMeta(
                     target as Node & RRNode,
                   ) as serializedElementNodeWithId;
-                  newSn.attributes = mutation.attributes as attributes;
+                  Object.assign(
+                    newSn.attributes,
+                    mutation.attributes as attributes,
+                  );
                   const newNode = buildNodeWithSN(newSn, {
                     doc: target.ownerDocument as Document, // can be Document or RRDocument
                     mirror: mirror as Mirror,