Fix for Elixir 1.17 #1136
Merged
Fix for Elixir 1.17 #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welp I gave it a shot. There are still 2 tests failing.
I do not understand yet what this |
|
#1132 is the related issue |
|
Found it :) here https://github.com/elixir-lang/elixir/blob/v1.17/lib/elixir/src/elixir_tokenizer.erl
So this is just the column number being incorrect. |
|
I think this will fix it: elixir-lang/elixir#13601 |
|
My elixir PR was closed. I don't think it is open for discussion, so I will change the tests to expect the new column number. |
7 tasks
|
@peaceful-james Thx for this! ✌️ |
|
@peaceful-james Please check out the RC to see if there are remaining issues: https://github.com/rrrene/credo/releases/tag/v1.7.7-rc.0 🧡 |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.