Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: %autosetup complains about no patches in range #3230

Closed
pmatilai opened this issue Aug 5, 2024 · 0 comments · Fixed by #3232
Closed

Regression: %autosetup complains about no patches in range #3230

pmatilai opened this issue Aug 5, 2024 · 0 comments · Fixed by #3232
Assignees

Comments

@pmatilai
Copy link
Member

pmatilai commented Aug 5, 2024

PR #3189 (commit d94dbcc) added a new warning to %autopatch in the case no patches are in range, but this now causes %autosetup to emit that message in a case where there aren't any patches to apply, which is a totally normal situation for %autosetup.

Also, the message added is really vague because there's no line number, passed arguments or such to help identify the cause in case there are many %autopatch invocations.

@pmatilai pmatilai added this to RPM Aug 5, 2024
@github-project-automation github-project-automation bot moved this to Backlog in RPM Aug 5, 2024
@pmatilai pmatilai moved this from Backlog to Todo in RPM Aug 5, 2024
@ffesti ffesti self-assigned this Aug 5, 2024
@ffesti ffesti moved this from Todo to Priority in RPM Aug 5, 2024
ffesti added a commit to ffesti/rpm that referenced this issue Aug 5, 2024
ffesti added a commit to ffesti/rpm that referenced this issue Aug 5, 2024
Add file and line number to the warning.

Suppress the warning when called from %autosetup and offer -q to
suppress the warning in general.

Resolves: rpm-software-management#3230
pmatilai pushed a commit that referenced this issue Aug 6, 2024
Ensure there isn't a warning created.

Related: #3230
pmatilai pushed a commit that referenced this issue Aug 6, 2024
Add file and line number to the warning.

Suppress the warning when called from %autosetup and offer -q to
suppress the warning in general.

Resolves: #3230
@github-project-automation github-project-automation bot moved this from Priority to Done in RPM Aug 6, 2024
dmnks pushed a commit to dmnks/rpm that referenced this issue Aug 29, 2024
Ensure there isn't a warning created.

Related: rpm-software-management#3230
(cherry picked from commit 6f08a20)
dmnks pushed a commit to dmnks/rpm that referenced this issue Aug 29, 2024
Add file and line number to the warning.

Suppress the warning when called from %autosetup and offer -q to
suppress the warning in general.

Resolves: rpm-software-management#3230
(cherry picked from commit 46b3e76)
dmnks pushed a commit that referenced this issue Aug 30, 2024
Ensure there isn't a warning created.

Related: #3230
(cherry picked from commit 6f08a20)
dmnks pushed a commit that referenced this issue Aug 30, 2024
Add file and line number to the warning.

Suppress the warning when called from %autosetup and offer -q to
suppress the warning in general.

Resolves: #3230
(cherry picked from commit 46b3e76)
pmatilai added a commit that referenced this issue Nov 19, 2024
Commit 46b3e76 added -q option to
%autopatch but only documented it in the main macros file and not the
manual.

Related: #3230
Related: #3093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants