dnf5: Statistics: total and downloaded pkgs size, installed and freed space #378

jrohel · 2023-03-20T12:33:02Z

Solves issue #342

jrohel · 2023-03-22T07:19:46Z

The code is ready, but we need to agree on the output format. Below are examples of the old DNF output and my suggestion of how the new output might look. However, we need to discuss the actual form of the new output.

dnf swap iftop atop (the package "atop" needs to be downloaded)
Old DNF:

Total download size: 199 k

Mising information about used space.

DNF5:

Total size of incoming pakages is 199 KiB. Need to download 199 KiB.
After unpacking 375 KiB will be used (installed 473 KiB, removed 98 KiB).

dnf swap iftop atop (the package "atop" is cached)
Old DNF:

Total size: 199 k

Mising information about used space.

DNF5:

Total size of incoming pakages is 199 KiB. Need to download 0 B.
After unpacking 375 KiB will be used (installed 473 KiB, removed 98 KiB).

dnf remove iftop
Old DNF:

Freed space: 98 k

DNF5:

Total size of incoming pakages is 0 B. Need to download 0 B.
After unpacking 98 KiB will be freed (installed 0 B, removed 98 KiB).

dnf install atop htop (the package "atop" is cached)
Old DNF:

Total size: 384 k
Total download size: 185 k
Installed size: 914 k

DNF5:

Total size of incoming pakages is 384 KiB. Need to download 185 KiB.
After unpacking 914 KiB will be used (installed 914 KiB, removed 0 B).

jan-kolarik · 2023-03-22T11:58:55Z

For me, it seems OK in most cases. But for the remove command I suppose the format could be different and less verbose as there will never be any incoming package, right? Btw typo pakages => packages.

jrohel · 2023-03-23T05:31:55Z

@jan-kolarik Thanks. I thinking about these changes:

fix typo pakages => packages
(installed 914 KiB, removed 0 B) => (install 914 KiB, remove 0 B)
Show Total size of incoming packages is... line only if there are incoming packages.

jan-kolarik · 2023-03-23T06:19:07Z

I am also wondering about the line for the remove command: "After unpacking 98 KiB will be freed". Maybe change the phrase to something more general like "After the operation xxx B of space will be used/freed"...

m-blaha · 2023-03-23T07:31:20Z

FWIW, on the API we use inbound/outbound terminology.
Ubuntu uses this wording:

Need to get 13.0 kB of archives.
After this operation, 53.2 kB of additional disk space will be used.

After this operation, 53.2 kB disk space will be freed.

m-blaha · 2023-03-23T07:39:00Z

And this is from zypper:

install:
Overall download size: 27.6 KiB. Already cached: 0 B. After the operation, additional 51.7 KiB will be used.

remove:
After the operation, 51.7 KiB will be freed.

jrohel · 2023-03-24T08:20:18Z

I made the above adjustments. And I replaced "incoming" with "inbound" as we have in the API.

The resulting output is:

Total size of inbound packages is 199 KiB. Need to download 199 KiB.
After unpacking 375 KiB will be used (install 473 KiB, remove 98 KiB).

The line Total size of inbound... is displayed only in the case of a non-zero value of inbound packages.

jrohel · 2023-03-24T08:30:20Z

I was considering whether to use "unpacking" or "operation". Neither is accurate. This is the size after unpacking files from inbound packages and deleting files from outbound (uninstalled/replaced) packages. But the size of the resulting operation may be different - scriptlets will generate/delete additional files (eg. initramfs).
I have no idea which word is better in this case.

m-blaha · 2023-03-24T12:23:46Z

Although I understand your point about accurateness, I would still prefer After this operation xx will be used/freed wording. This way the line could remain the same for any transaction, regardless it's install or remove.
In the documentation we can describe in detail that these numbers cover only sum of packages sizes from metadata.

The class template `OnScopeExit` is a general-purpose scope guard intended to call its exit function when a scope is exited.

Returns `true` if the package is available locally (in cache, command line package).

`format_size` produces partially aligned output with one decimal place. Examples: "25.0 B", "4.0 KiB" Therefore, the function was renamed to `format_size_aligned`. We often need a different format. That's why the function `to_size` was created, which returns a pair of float value and unit. The user can then format the output as desired.

jrohel · 2023-03-27T08:29:37Z

@m-blaha OK. I rebased the PR and changed the message to After this operation xxx will be used/freed (install xxx, remove xxx)..

jan-kolarik · 2023-03-28T12:13:56Z

libdnf/utils/on_scope_exit.hpp

+/// The class template OnScopeExit is a general-purpose scope guard
+/// intended to call its exit function when a scope is exited.
+template <typename TExitFunction>
+    requires requires(TExitFunction f) {


Nice, that's a first occurrence of C++20 concepts I've seen in our project 🙂

jan-kolarik

Great, thanks!

jrohel added the work in progress label Mar 20, 2023

jrohel force-pushed the feature/total_download_installed_size branch from 476982e to 4a7baa1 Compare March 20, 2023 12:37

jan-kolarik self-assigned this Mar 21, 2023

jrohel force-pushed the feature/total_download_installed_size branch 2 times, most recently from 7391c69 to f3dd6c6 Compare March 22, 2023 06:13

jrohel force-pushed the feature/total_download_installed_size branch from f3dd6c6 to d4d0148 Compare March 22, 2023 07:21

jrohel force-pushed the feature/total_download_installed_size branch from d4d0148 to 1292eed Compare March 24, 2023 08:10

jrohel added 6 commits March 27, 2023 10:09

Create utils::OnScopeExit template class

afd1691

The class template `OnScopeExit` is a general-purpose scope guard intended to call its exit function when a scope is exited.

New API method rpm::Package::is_available_locally

a7ed14f

Returns `true` if the package is available locally (in cache, command line package).

cli::utils::units::format_size: Fix formatting of negative numbers

e155c56

dnf5::Context::print_info: Make method const and public

be6a71d

dnf5: Stats: total and downloaded pkgs size, installed and freed space

849204a

jrohel force-pushed the feature/total_download_installed_size branch from 1292eed to 849204a Compare March 27, 2023 08:26

jrohel added ready for review and removed work in progress labels Mar 27, 2023

jan-kolarik reviewed Mar 28, 2023

View reviewed changes

jan-kolarik approved these changes Mar 28, 2023

View reviewed changes

jan-kolarik merged commit 8830772 into rpm-software-management:main Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dnf5: Statistics: total and downloaded pkgs size, installed and freed space #378

dnf5: Statistics: total and downloaded pkgs size, installed and freed space #378

jrohel commented Mar 20, 2023 •

edited

Loading

jrohel commented Mar 22, 2023

jan-kolarik commented Mar 22, 2023

jrohel commented Mar 23, 2023 •

edited

Loading

jan-kolarik commented Mar 23, 2023

m-blaha commented Mar 23, 2023

m-blaha commented Mar 23, 2023

jrohel commented Mar 24, 2023

jrohel commented Mar 24, 2023

m-blaha commented Mar 24, 2023

jrohel commented Mar 27, 2023

jan-kolarik Mar 28, 2023

jan-kolarik left a comment

dnf5: Statistics: total and downloaded pkgs size, installed and freed space #378

dnf5: Statistics: total and downloaded pkgs size, installed and freed space #378

Conversation

jrohel commented Mar 20, 2023 • edited Loading

jrohel commented Mar 22, 2023

jan-kolarik commented Mar 22, 2023

jrohel commented Mar 23, 2023 • edited Loading

jan-kolarik commented Mar 23, 2023

m-blaha commented Mar 23, 2023

m-blaha commented Mar 23, 2023

jrohel commented Mar 24, 2023

jrohel commented Mar 24, 2023

m-blaha commented Mar 24, 2023

jrohel commented Mar 27, 2023

jan-kolarik Mar 28, 2023

Choose a reason for hiding this comment

jan-kolarik left a comment

Choose a reason for hiding this comment

jrohel commented Mar 20, 2023 •

edited

Loading

jrohel commented Mar 23, 2023 •

edited

Loading