Set a minimal sqlite version #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing a package on a system with sqlite-3.34.1 failed with:
Running transaction
SQL statement compilation failed: "
INSERT INTO
"pkg_name" (
"name"
)
VALUES
(?)
ON CONFLICT DO NOTHING
RETURNING "id"
": (1) - SQL logic error
The cause is that libdnf5 uses "RETURNING" clause in sqlite queries.
A support for this clause was added in sqlite-3.35.0. (Figured out
experimentally and by reading sqlite sources. Sqlite news file only
mentions "adds a number of new language features".)
This patch constrains the minial sqlite version to 3.35.0.
|
LGTM |
|
I'm sorry, there was a typo in an added Requires: line. It was caught by CI https://github.com/rpm-software-management/dnf5/actions/runs/4448244007/jobs/7811691829. I will supply a fix. |
|
Fix supplied in #374. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing a package on a system with sqlite-3.34.1 failed with:
The cause is that libdnf5 uses "RETURNING" clause in sqlite queries. A support for this clause was added in sqlite-3.35.0. (Figured out experimentally and by reading sqlite sources. Sqlite news file only mentions "adds a number of new language features".)
This patch constrains the minial sqlite version to 3.35.0.