Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logger: Add support for logging in API scripts #333

Merged
merged 7 commits into from
Mar 15, 2023
Merged

logger: Add support for logging in API scripts #333

merged 7 commits into from
Mar 15, 2023

Conversation

jan-kolarik
Copy link
Member

@jan-kolarik jan-kolarik commented Mar 6, 2023 •
edited
Loading

Create helper method for easily creating a file logger based on configured file path. The logic was separated from the main to its own file in order to be usable for API users.

Also added bindings for GlobalLogger class to setup libraries logging in API scripts.

@jan-kolarik jan-kolarik changed the title logger: Add factory method for creating file loggers logger: Add factory method for creating the file logger Mar 6, 2023
@jan-kolarik jan-kolarik force-pushed the jkolarik/file-logger-factory branch from c0aa39e to b92345f Compare March 7, 2023 05:57
@jan-kolarik jan-kolarik changed the title logger: Add factory method for creating the file logger logger: Add support for logging in API scripts Mar 7, 2023
@jan-kolarik jan-kolarik force-pushed the jkolarik/file-logger-factory branch from 2649846 to 3f3a893 Compare March 7, 2023 08:47
@jan-kolarik
logger: Add factory method for creating file logger
bd7d612 
Create helper method for easily creating a file logger based on configured file path.

This can be used to easily setup file logging for API users.
@jan-kolarik
main: Use new factory for file logging
4f76618
@jan-kolarik jan-kolarik force-pushed the jkolarik/file-logger-factory branch from 3f3a893 to 338c175 Compare March 13, 2023 08:06
@jan-kolarik jan-kolarik force-pushed the jkolarik/file-logger-factory branch from 338c175 to b635dc1 Compare March 13, 2023 08:10
@m-blaha m-blaha self-assigned this Mar 13, 2023
m-blaha
m-blaha approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me.

@m-blaha m-blaha merged commit 60ec470 into main Mar 15, 2023
@m-blaha m-blaha deleted the jkolarik/file-logger-factory branch March 15, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-blaha m-blaha m-blaha approved these changes

Assignees

@m-blaha m-blaha

Labels
None yet
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-kolarik @m-blaha