Prefer transaction.download() over directly using PackageDownloader #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfdfb0 to
a8e6db1
Compare
j-mracek
reviewed
Feb 22, 2023
j-mracek
reviewed
Feb 22, 2023
a8e6db1 to
48bf4d2
Compare
|
@m-blaha May I ask you for your opinion for part related to Daemon? |
j-mracek
reviewed
Mar 2, 2023
Signed-off-by: Evan Goode <mail@evangoo.de>
48bf4d2 to
42364d3
Compare
|
Looks like we're back to passing integration tests. |
|
LGTM |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new transaction.download() in a couple places instead of using PackageDownloader directly.
Not sure whether it's worth it to use it here since download callbacks need to be set up.