Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move clang-format back to the latest Fedora #304

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Feb 17, 2023

Now when the dnf-ci-host is back on the latest Fedora we can revert this
temporary workaround.
The current clang-format requires this small change in the code.
@m-blaha m-blaha added the blocked Further work on issue or PR is blocked by something else label Feb 17, 2023
@m-blaha
Copy link
Member Author

m-blaha commented Feb 17, 2023

The Clang Format test failure is expected till the dnf-ci-host container moves to the latest Fedora (rpm-software-management/ci-dnf-stack#1223)

@kontura kontura self-assigned this Feb 20, 2023
@kontura
Copy link
Contributor

kontura commented Feb 20, 2023

@m-blaha is this still blocked since rpm-software-management/ci-dnf-stack#1223 was merged? I have recreated the ci-host container and the clang format succeeded here.

@m-blaha
Copy link
Member Author

m-blaha commented Feb 20, 2023

No, thanks. Only recreation of ci-host container was needed.

@m-blaha m-blaha added ready for review and removed blocked Further work on issue or PR is blocked by something else labels Feb 20, 2023
@kontura
Copy link
Contributor

kontura commented Feb 20, 2023

Thank you!

@kontura kontura merged commit ef84f77 into main Feb 20, 2023
@kontura kontura deleted the mblaha/clang_format branch February 20, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants