Fix path for files in /usr/share #285
Conversation
|
Maybe I am missing something, but I don't see those files anywhere else in the |
| @@ -173,9 +173,6 @@ It supports RPM packages, modulemd modules, and comps groups & environments. | |||
| %{_prefix}/share/dnf5 | |||
| %dir %{_sysconfdir}/dnf/dnf5-aliases.d | |||
| %doc %{_sysconfdir}/dnf/dnf5-aliases.d/README | |||
| %dir %{_prefix}/lib/dnf5 | |||
| %dir %{_prefix}/lib/dnf5/aliases.d | |||
| %config %{_prefix}/lib/dnf5/aliases.d/compatibility.conf | |||
There was a problem hiding this comment.
I think the problem here is a bit different here. %{_prefix}/lib/dnf5 translates to /usr/lib/dnf5 but we do not ship any files in this location.
But we do have files in /usr/share/dnf5/ which is %{_datadir}/dnf5/. I suggest to replace %{_prefix}/lib/dnf5 with %{_datadir}/dnf5 on these three lines and remove %{_prefix}/share/dnf5 on line 173.
There was a problem hiding this comment.
oh, I had the description wrong. The files are indeed duplicate in /usr/share/dnf5, which we ship.
originally aliases.d and such were in /usr/lib but got moved in /usr/share.
The pr intends to remove the duplicate files in /usr/share/dnf5 but mistakenly I confused the path in the description.
I will update the pr accordingly to what proposed
There was a problem hiding this comment.
Oh, I see, thanks. The clang builds are failing on rawhide again, but that's a different issue.
d71e821 to
446c1d0
Compare
446c1d0 to
3791a61
Compare
| @@ -173,9 +173,6 @@ It supports RPM packages, modulemd modules, and comps groups & environments. | |||
| %{_prefix}/share/dnf5 | |||
| %dir %{_sysconfdir}/dnf/dnf5-aliases.d | |||
| %doc %{_sysconfdir}/dnf/dnf5-aliases.d/README | |||
| %dir %{_prefix}/lib/dnf5 | |||
| %dir %{_prefix}/lib/dnf5/aliases.d | |||
| %config %{_prefix}/lib/dnf5/aliases.d/compatibility.conf | |||
There was a problem hiding this comment.
Oh, I see, thanks. The clang builds are failing on rawhide again, but that's a different issue.
Some files got added twice in f8e861b