Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation used rpmvercmp() on the whole EVR. But unfortunatelly rpmvercmp does not do any NEVRA parsing, it just compares two strings, which led to incorrect results.
For example these packages are in the current code ordered wrong:
firefox-0:100.0-2.fc36.x86_64
firefox-0:109.0.1-1.fc36.x86_64
the reason is that rmpvercmp() correctly returns that '0:100.0-2.fc36' version string is higher than '0:109.0.1-1.fc36'. But what is true for strings is not true for EVR. We need to compare each part (epoch, version, and release) separately.
For this a new evrcmp() function is introduced.