Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set POOL_FLAG_WHATPROVIDESWITHDISABLED to libsolv pool #261

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

j-mracek
Copy link
Contributor

@j-mracek j-mracek commented Feb 1, 2023

POOL_FLAG_WHATPROVIDESWITHDISABLED ensures that excluded packages are not taken as candidates for solver. This is specific behavior is unique for DNF, because we runs make provides ready on top of all packages including excluded packages.

Resolves: openSUSE/libsolv#518

POOL_FLAG_WHATPROVIDESWITHDISABLED ensures that excluded packages are
not taken as candidates for solver. This is specific behavior is unique
for DNF, because we runs make provides ready on top of all packages
including excluded packages.

Resolves: openSUSE/libsolv#518
@kontura kontura self-assigned this Feb 2, 2023
@kontura
Copy link
Contributor

kontura commented Feb 6, 2023

I think the Resolves link you mentioned should probably be: #222?

If that is the case we need a new test for the issue since rpm-software-management/ci-dnf-stack#1211 seems to work even without the POOL_FLAG_WHATPROVIDESWITHDISABLED flag.

@j-mracek
Copy link
Contributor Author

j-mracek commented Feb 6, 2023

I think the Resolves link you mentioned should probably be: #222?

If that is the case we need a new test for the issue since rpm-software-management/ci-dnf-stack#1211 seems to work even without the POOL_FLAG_WHATPROVIDESWITHDISABLED flag.

This patch also remove solver error, but the original patch (added targeted) change behavior according to DNF5 behavior. The difference is if I specify exact version of installed package then you will see the difference.

installed
a-1-1.noarch

Available
a-1-1.noarch
a-2-2.noarch

command
dnf5 distro-sync a-1-1.noarch

The current behavior
No action

Without targeted flag:
updrade to a-2-2.noarch

@kontura
Copy link
Contributor

kontura commented Feb 7, 2023

I see, both POOL_FLAG_WHATPROVIDESWITHDISABLED or setting the job as targeted resolve the issue.

I was just thinking how to create a test for this (for when the POOL_FLAG_WHATPROVIDESWITHDISABLED is not set). Maybe using some other command than distro-sync that is not targeted?

@kontura kontura merged commit f778704 into rpm-software-management:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

distupgrade recognize disabled packages as best candidates
2 participants