Handle std::filesystem::directory_iterator errors #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Jan 30, 2023
| libdnf::repo::RepoCache::RemoveStatistics statistics{}; | ||
| for (const auto & dir_entry : std::filesystem::directory_iterator(cachedir)) { | ||
| for (const auto & dir_entry : std::filesystem::directory_iterator(cachedir, ec)) { |
There was a problem hiding this comment.
Is it intended, that issues are silent?
There was a problem hiding this comment.
In most cases yes. But thinking about this particular case - we can print a warning to std::err.
233c481 to
e410972
Compare
Setting *dir config options to non-existing or non-accessible directory leads to unnecessary crash. Resolves: #249
e410972 to
dc93495
Compare
|
The CI tests are failing due to syntax error in feature file - rpm-software-management/ci-dnf-stack#1213 |
|
LGTM, please feel free to merge it when all tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting *dir config options to non-existing or non-accessible directory leads to unnecessary crash.
In case of reposdir also a warning is written to the log.
Resolves: #249