RepoSack::update_and_load_repos: First load repositories from cache #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f7b7d6 to
8aa6def
Compare
499871a to
dbb6480
Compare
Work optimization. The order in which the repositories are loaded into the sack is changed. Repositories with a valid cache are sent to the `thread_sack_loader` before downloading other repositories.
Removes the automatic download and import of keys from the repo::RepoDownloader::perform method. It is now automatically done in the repo::RepoSack::update_and_load_repos method. The advantage is optimization. First, all repositories that do not have a problem with key verification are prepared for uploading to the sack. Then keys are downloaded/imported for repositories with bad keys. These repositories are then verified again and, if successful, further processed.
It is now possible to call `repo::RepoSack::update_and_load_repos` with download and import key support disabled.
… keys Uses `FileDownloader` class to download repository keys instead of `download_url` method from `RepoDownloader`. A repository independent librepo handler is now used and multiple key files can be downloaded in parallel.
Removes downloading/copying of local files to temporary files. Repositories keys are imported from local files directly from their original location. Then remote keys files are downloaded and imported.
dbb6480 to
3c63ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizing resource usage in
RepoSack::update_and_load_repo.The order of uploading repositories to the sack has been changed.
thread_sack_loader.thread_sack_loaderis uploading prepared repositories to the sack, the remaining repositories (repositories with invalid or empty cache) are downloaded.Downloading and importing repository keys has been changed: