Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of autodetecting modular platform ID #243

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Implementation of autodetecting modular platform ID #243

merged 4 commits into from
Feb 8, 2023

Conversation

jan-kolarik
Copy link
Member

Platform ID for modules is automatically detected based on the following values in given order sorted by priority:

  1. Use module_platform_id configuration option value, if it is explicitly set up.
  2. Parse Provides value from the latest available package in enabled repositories.
  3. Parse Provides value from the latest installed package on the local system.
  4. Parse PLATFORM_ID value from os-release files on the local system.

The logic is implemented based on the original PR from libdnf component.

@j-mracek j-mracek self-assigned this Jan 20, 2023
@jan-kolarik jan-kolarik marked this pull request as ready for review January 26, 2023 14:28
@jan-kolarik
Copy link
Member Author

Note: was not yet properly tested as modules enable, disable, etc. functionality is missing for now.

j-mracek
j-mracek suggested changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@j-mracek j-mracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks fine, but there are few issues that I would like to see modified.

@j-mracek j-mracek mentioned this pull request Jan 31, 2023
Merged
@jan-kolarik jan-kolarik force-pushed the jkolarik/module-platform_id-detection branch from 695bf88 to ba27fd3 Compare February 7, 2023 12:43
@jan-kolarik
Copy link
Member Author

Note: was not yet properly tested as modules enable, disable, etc. functionality is missing for now.

Functionality for now successfully tested using the original DNF command for enabling a specific module stream and then trying to do a repoquery and install with DNF5 and checking if seeing modular packages there.

@jan-kolarik
module_item: Method for creating platform solvable
0ecd0a2 
Static method for creating a virtual platform solvable package was added to be used for automatic module platform id detection.
@jan-kolarik
module_sack: Automatic platform id detection
aaeed0c 
Implementation of automatic module platform id detection based on the logic from the original DNF code.
@jan-kolarik
conf: Restrict module_platform_id format
6185269 
Setup regex format to allow only platform ids with non-empty name and stream while containing the colon character.
@jan-kolarik
module: Improve docs related to platform detection
7dd1f4d 
Add docstrings and adjust logging levels.
@jan-kolarik jan-kolarik force-pushed the jkolarik/module-platform_id-detection branch from ba8aecb to 7dd1f4d Compare February 8, 2023 09:03
j-mracek
j-mracek approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@j-mracek j-mracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j-mracek j-mracek merged commit b6623c9 into main Feb 8, 2023
@j-mracek j-mracek deleted the jkolarik/module-platform_id-detection branch February 8, 2023 12:21
@jan-kolarik jan-kolarik linked an issue Feb 10, 2023 that may be closed by this pull request
Implement detection of Platform Id for modules #171
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-mracek j-mracek j-mracek approved these changes

Assignees

@j-mracek j-mracek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement detection of Platform Id for modules
2 participants
@jan-kolarik @j-mracek