SWIG: drop the std::optional from the public API #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8ce188d to
4bb56c3
Compare
|
Note: CI tests are failing due to API change in binding. This is resolved in related PR rpm-software-management/ci-dnf-stack#1200. |
819b3f3 to
4bb56c3
Compare
j-mracek
reviewed
Jan 9, 2023
j-mracek
reviewed
Jan 9, 2023
j-mracek
reviewed
Jan 9, 2023
j-mracek
reviewed
Jan 9, 2023
j-mracek
reviewed
Jan 9, 2023
4bb56c3 to
3c36619
Compare
f02e9c3 to
692bc79
Compare
As SWIG bindings don't support std::optional wrappers, moving to default empty string value as an alternative.
As SWIG bindings don't support std::optional wrappers, moving the GoalJobSettings fields into private part of the class.
As SWIG bindings don't support std::optional wrappers, moving to default empty string parameter value as an alternative.
As SWIG bindings don't support std::optional wrappers, moving the fields into private part of the class and switch to raw pointer getters.
As SWIG bindings don't support std::optional wrappers, moving to raw pointer getter.
As SWIG bindings don't support std::optional wrappers, switching the run() method parameters to have default values instead. Also parameters reordering was done, because more common usecase is not passing the user_id parameter.
Expose `advisory_filter` and `group_package_types` through getters on the `GoalJobSettings` struct.
692bc79 to
393f819
Compare
|
LGTM |
j-mracek
approved these changes
Feb 2, 2023
|
@jan-kolarik It looks like that some test is failing. May I ask you to investigate the issue. |
Yes, these are the API bindings tests, because of the change in the API. There is a PR mentioned in the previous comment fixing this (rpm-software-management/ci-dnf-stack#1200). |
|
LGTM |
|
Thank you very much for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWIG bindings don't support the
std::optionaltype wrappers, so this PR aims to drop all these references away from the public API.Closes #186.