Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search command: initial version #202

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Search command: initial version #202

merged 4 commits into from
Feb 15, 2023

Conversation

jan-kolarik
Copy link
Member

Introducing a search command.

The output is very similar to the existing command in DNF.

For now probably the only functionality missing is the grouping of the results based on the matched patterns. Now only grouping based on the matched metadata keys is present. This could be implemented later if it is found useful for clients.

Related issue link: #152

@jan-kolarik
Copy link
Member Author

jan-kolarik commented Dec 16, 2022 •
edited
Loading

Example screenshot:

image

@jan-kolarik jan-kolarik force-pushed the jkolarik/search-command branch from 3e8a85d to d19d0a1 Compare December 16, 2022 14:32
@jan-kolarik jan-kolarik linked an issue Jan 4, 2023 that may be closed by this pull request
Implement search command #152
Closed
3 tasks
@pkratoch pkratoch self-assigned this Jan 10, 2023
@jan-kolarik jan-kolarik force-pushed the jkolarik/search-command branch from d19d0a1 to dda3af0 Compare January 13, 2023 14:11
@jan-kolarik jan-kolarik removed a link to an issue Jan 16, 2023
Implement search command #152
Closed
3 tasks
@jan-kolarik jan-kolarik mentioned this pull request Jan 16, 2023
Closed
3 tasks
@mcurlej mcurlej added this to the Fedora 38 milestone Jan 18, 2023
pkratoch
pkratoch reviewed Jan 18, 2023
View reviewed changes
doc/commands/search.8.rst Outdated Show resolved Hide resolved
pkratoch
pkratoch reviewed Jan 18, 2023
View reviewed changes
doc/commands/search.8.rst Outdated Show resolved Hide resolved
@jan-kolarik
search: Output implementation
3f0ad06 
Introducing a class handling the search command output.

Issue link: #152
@jan-kolarik
search: Implementation of logic
204a884 
Introducing a class handling the search command logic.

Issue link: #152
@jan-kolarik
search: Connect command to new logic
b24c88a 
Connect existing search command with newly introduced logic and output classes and add the command back to the infrastructure.

Issue link: #152
@jan-kolarik
search: Documentation
29d0b44 
Create search command man page.

Issue link: #152
@jan-kolarik jan-kolarik force-pushed the jkolarik/search-command branch from dda3af0 to 29d0b44 Compare February 10, 2023 09:09
@jan-kolarik
Copy link
Member Author

jan-kolarik commented Feb 10, 2023 •
edited
Loading

Note: I used std::views in my initial implementation of reversing the std::map keys order in search_processor.cpp which was fine with gcc, but not yet supported with clang compiler for now (only in experimental setup). So I switched to a different solution.

@jan-kolarik jan-kolarik mentioned this pull request Feb 15, 2023
Open
@pkratoch
Copy link
Contributor

Looks good, thanks for the fixes.

@pkratoch pkratoch merged commit b382928 into main Feb 15, 2023
@pkratoch pkratoch deleted the jkolarik/search-command branch February 15, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inknos inknos inknos left review comments

@pkratoch pkratoch pkratoch left review comments

Assignees

@pkratoch pkratoch

Labels
None yet
Projects
DNF team
Archived in project
Milestone
Fedora 38
Development

Successfully merging this pull request may close these issues.
4 participants
@jan-kolarik @pkratoch @inknos @mcurlej