Revert "Drop errorlevel config option"
#1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisar
reviewed
Oct 22, 2024
0518f06 to
8d74a48
Compare
|
The required formatting seems a bit odd but I have updated it. I have also renamed the commit. 👍 |
ppisar
reviewed
Oct 22, 2024
Merged
via the queue into
rpm-software-management:main
with commit Oct 23, 2024
1a57764
20 checks passed
kontura
added a commit
to kontura/dnf5
that referenced
this pull request
Dec 6, 2024
The old `ubuntu-22.04` uses version `swig4.0` which fails on C++11 attributes. We have started to use them in: rpm-software-management#1793 and the readthedocs build has been failing since then. Use `24.04` (https://about.readthedocs.com/blog/2024/06/ubuntu-24-04/) because it uses `swig_4.2.0` which atleast ignores the attributes. According to the changelog the attributes should be ingnored since version 4.1.0: https://www.swig.org/Release/CHANGES ``` 2022-07-07: jmarrec rpm-software-management#1158 #2286 Add basic support for C++11 attributes. These are now crudely ignored by SWIG's parser's tokeniser, which is better than failing with a parse error. ```
kontura
added a commit
to kontura/dnf5
that referenced
this pull request
Dec 6, 2024
The old `ubuntu-22.04` uses version `swig4.0` which fails on C++11 attributes. We have started to use them in: rpm-software-management#1793 and the readthedocs build has been failing since then. Use `24.04` (https://about.readthedocs.com/blog/2024/06/ubuntu-24-04/) because it uses `swig_4.2.0` which at least ignores the attributes. According to the changelog the attributes should be ignored since version 4.1.0: https://www.swig.org/Release/CHANGES ``` 2022-07-07: jmarrec rpm-software-management#1158 #2286 Add basic support for C++11 attributes. These are now crudely ignored by SWIG's parser's tokeniser, which is better than failing with a parse error. ```
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
The old `ubuntu-22.04` uses version `swig4.0` which fails on C++11 attributes. We have started to use them in: #1793 and the readthedocs build has been failing since then. Use `24.04` (https://about.readthedocs.com/blog/2024/06/ubuntu-24-04/) because it uses `swig_4.2.0` which at least ignores the attributes. According to the changelog the attributes should be ignored since version 4.1.0: https://www.swig.org/Release/CHANGES ``` 2022-07-07: jmarrec #1158 #2286 Add basic support for C++11 attributes. These are now crudely ignored by SWIG's parser's tokeniser, which is better than failing with a parse error. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the defunct options to preserve API.
Revert: #1788
It keeps the docs update.