comps: Fix memory issues in group serialization #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses two memory issues that occur if saving of the group XML file fails: Memory leak: The `doc` variable is not properly freed before an error is thrown, leading to a memory leak. Use after free: The libxml2 error handler continues to reference the `error_to_strings()` function, which uses the `xml_errors` vector that is local to the `Group::serialize()` method. If the handler is invoked later (e.g., during the serialization of an Environment), it may cause a crash due to accessing freed memory. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2315789
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses two memory issues that occur if saving of the
group XML file fails:
Memory leak: The
docvariable is not properly freed before an error isthrown, leading to a memory leak.
Use after free: The libxml2 error handler continues to reference the
error_to_strings()function, which uses thexml_errorsvector thatis local to the
Group::serialize()method. If the handler is invokedlater (e.g., during the serialization of an Environment), it may cause a
crash due to accessing freed memory.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2315789