dnfdaemon: Correct D-Bus signal argument type #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct_path argument The interface is defined as the "session_object_path" is of type "object_path", but when setting the arguments it's passing the path as a string, which causes a type mismatch and the client side can reject the signal. Store the object path as an sdbus::ObjectPath in the Session class to have correct types in the signal emission. Closes rpm-software-management#1646
…::cancel method Both the arguments are output arguments, to be read by client, not to be set by the client, thus mark them as such. Related to rpm-software-management#1665 (comment)
5b6b217 to
e0f7b91
Compare
mcrha
referenced
this pull request
Sep 6, 2024
It looks like the server is sending session_object_path argument as a string, although it is declared as "object path" type. Changing to strings to resolve runtime warnings on the client side. See #1646 for details.
Merged
via the queue into
rpm-software-management:main
with commit Sep 6, 2024
d7101b3
12 of 20 checks passed
kontura
added a commit
to kontura/dnf5
that referenced
this pull request
Sep 19, 2024
Since rpm-software-management#1679 `get_session_object_path()` returns `sdbus::ObjectPath` we cannot compare it to `std::string`. Convert both to `sdbus::ObjectPath`. This was causing the check `signature_valid(sdbus::Signal &)` to return `false`, the client callback ended and the server kept waiting for result of the `key_import` userconfirm.
kontura
added a commit
to kontura/dnf5
that referenced
this pull request
Sep 20, 2024
Since rpm-software-management#1679 `sdbus::ObjectPath` is send over to the client not std::string. This was causing the check `signature_valid(sdbus::Signal &)` to crash, the client callback ended and the server kept waiting for result of the `key_import` userconfirm.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Since #1679 `sdbus::ObjectPath` is send over to the client not std::string. This was causing the check `signature_valid(sdbus::Signal &)` to crash, the client callback ended and the server kept waiting for result of the `key_import` userconfirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the two commits for more info.
Resolves: #1646
Resolves: #1665 (comment)