Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend a plugin to resolve expired GPG keys #2166

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Dec 2, 2024

Fix #2156

@FrostyX
Copy link
Member Author

FrostyX commented Dec 2, 2024

I wanted to kick this off. We can figure out a better error message or a better place in the code here.

The output now looks like this:

The GPG keys listed for the "Copr repo for neovim-nightly owned by agriffis" repository are already installed but they are not correct for this package.
Check that the correct key URLs are configured for this repository.. Failing package is: libtree-sitter-0.24.1~git.130.ge445532a-1.fc41.x86_64
 GPG Keys are configured as: https://download.copr.fedorainfracloud.org/results/agriffis/neovim-nightly/pubkey.gpg
Public key for neovim-0.11.0~dev.1267.gc1378413c-1.fc41.x86_64.rpm is not trusted. Failing package is: neovim-0.11.0~dev.1267.gc1378413c-1.fc41.x86_64
 GPG Keys are configured as: https://download.copr.fedorainfracloud.org/results/agriffis/neovim-nightly/pubkey.gpg
Public key for utf8proc-2.9.0+git.11.g3de4596-59.fc41.x86_64.rpm is not trusted. Failing package is: utf8proc-2.9.0+git.11.g3de4596-59.fc41.x86_64
 GPG Keys are configured as: https://download.copr.fedorainfracloud.org/results/agriffis/neovim-nightly/pubkey.gpg

Use the `--enableplugin=expired-pgp-keys' paremeter to resolve the problem.

The downloaded packages were saved in cache until the next successful transaction.
You can remove cached packages by executing 'dnf clean packages'.
Error: GPG check FAILED

dnf/cli/cli.py Outdated Show resolved Hide resolved
@FrostyX FrostyX force-pushed the recommend-gpg-keys-plugin branch from 6cf18a7 to 3516532 Compare December 2, 2024 19:42
@FrostyX
Copy link
Member Author

FrostyX commented Jan 6, 2025

bump

@jan-kolarik jan-kolarik self-assigned this Jan 7, 2025
@jan-kolarik
Copy link
Member

jan-kolarik commented Jan 7, 2025

Hey @FrostyX, sorry for late response, I've tried to improve the proposed behavior a bit. It's mainly about narrowing the cases when the suggestion message is shown and also a slight modification of the message. Please check it and I can then adjust the commits to the final state.

@FrostyX
Copy link
Member Author

FrostyX commented Jan 7, 2025

No problem @jan-kolarik. The proposed change looks good to me.

@jan-kolarik jan-kolarik force-pushed the recommend-gpg-keys-plugin branch from 709cd6d to e9f496a Compare January 9, 2025 09:35
When PGP key for a repository is installed, but already expired, suggest enabling the expired-pgp-keys plugin to reimport the new key and resolve the issue.

Co-authored-by: Jakub Kadlcik <frostyx@email.cz>
@jan-kolarik jan-kolarik force-pushed the recommend-gpg-keys-plugin branch from e9f496a to 570a414 Compare January 9, 2025 10:04
@jan-kolarik jan-kolarik merged commit eabf33a into rpm-software-management:master Jan 9, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On GPG check FAILED recommend using --enableplugin=expired-pgp-keys
3 participants