Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug on almalinux 9 #1905

Closed
tuxmika opened this issue Mar 10, 2023 · 1 comment · Fixed by #1907
Closed

Bug on almalinux 9 #1905

tuxmika opened this issue Mar 10, 2023 · 1 comment · Fixed by #1907
Assignees
@evan-goode

Comments

@tuxmika
Copy link

tuxmika commented Mar 10, 2023

Hi,

I have these messages on almalinux 9/ Rocky Linux 9

[mickael@srvalmalinux ~]$ sudo /usr/bin/dnf-automatic /etc/dnf/automatic.conf --timer
Last metadata expiration check: 2:45:52 ago on Fri Mar 10 14:38:38 2023.
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
Traceback (most recent call last):
File "/usr/bin/dnf-automatic", line 36, in
sys.exit(dnf.automatic.main.main(sys.argv[1:]))
File "/usr/lib/python3.9/site-packages/dnf/automatic/main.py", line 342, in main
emitters.commit()
File "/usr/lib/python3.9/site-packages/dnf/util.py", line 526, in fn
return list(map(call_what, self))
File "/usr/lib/python3.9/site-packages/dnf/util.py", line 525, in call_what
return method(*args, **kwargs)
File "/usr/lib/python3.9/site-packages/dnf/automatic/emitter.py", line 106, in commit
smtp = smtplib.SMTP(self._conf.email_host, timeout=300)
File "/usr/lib64/python3.9/smtplib.py", line 255, in init
(code, msg) = self.connect(host, port)
File "/usr/lib64/python3.9/smtplib.py", line 341, in connect
self.sock = self._get_socket(host, port, self.timeout)
File "/usr/lib64/python3.9/smtplib.py", line 312, in _get_socket
return socket.create_connection((host, port), timeout,
File "/usr/lib64/python3.9/socket.py", line 844, in create_connection
raise err
File "/usr/lib64/python3.9/socket.py", line 832, in create_connection
sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused
@evan-goode evan-goode self-assigned this Mar 13, 2023
evan-goode added a commit to evan-goode/dnf that referenced this issue Mar 13, 2023
@evan-goode
smtplib: catch OSError, not SMTPException
5752b0d 
Some, but not all, types of connection error are caught by smtplib and
reraised as an smtplib.SMTPException. Notably, TimeoutError,
socket.gaierror (name resolution failure), and ConnectionRefusedError
and are not caught.

The more generic OSError should be caught here instead.

Resolves rpm-software-management#1905
@evan-goode evan-goode mentioned this issue Mar 13, 2023
Merged
@evan-goode
Copy link
Member

Thanks for reporting! Looks like the issue is that dnf-automatic couldn't connect to your SMTP server, but yes, these errors should be caught and logged properly rather than cause a crash.

Will be fixed by #1907.

kontura pushed a commit that referenced this issue Mar 14, 2023
@evan-goode @kontura
smtplib: catch OSError, not SMTPException
aab7def 
Some, but not all, types of connection error are caught by smtplib and
reraised as an smtplib.SMTPException. Notably, TimeoutError,
socket.gaierror (name resolution failure), and ConnectionRefusedError
and are not caught.

The more generic OSError should be caught here instead.

Resolves #1905
m-blaha pushed a commit that referenced this issue Oct 7, 2024
@evan-goode @m-blaha
smtplib: catch OSError, not SMTPException
4d7aeb6 
Some, but not all, types of connection error are caught by smtplib and
reraised as an smtplib.SMTPException. Notably, TimeoutError,
socket.gaierror (name resolution failure), and ConnectionRefusedError
and are not caught.

The more generic OSError should be caught here instead.

Resolves #1905
ppisar pushed a commit that referenced this issue Oct 7, 2024
@evan-goode @ppisar
smtplib: catch OSError, not SMTPException
ea2d17c 
Some, but not all, types of connection error are caught by smtplib and
reraised as an smtplib.SMTPException. Notably, TimeoutError,
socket.gaierror (name resolution failure), and ConnectionRefusedError
and are not caught.

The more generic OSError should be caught here instead.

Resolves #1905
m-blaha pushed a commit that referenced this issue Dec 13, 2024
@evan-goode @m-blaha
smtplib: catch OSError, not SMTPException
8b26692 
Upstream commit: aab7def

Some, but not all, types of connection error are caught by smtplib and
reraised as an smtplib.SMTPException. Notably, TimeoutError,
socket.gaierror (name resolution failure), and ConnectionRefusedError
and are not caught.

The more generic OSError should be caught here instead.

Resolves #1905
Resolves: https://issues.redhat.com/browse/RHEL-46030
kontura pushed a commit that referenced this issue Dec 13, 2024
@evan-goode @kontura
smtplib: catch OSError, not SMTPException
a1feaf8 
Upstream commit: aab7def

Some, but not all, types of connection error are caught by smtplib and
reraised as an smtplib.SMTPException. Notably, TimeoutError,
socket.gaierror (name resolution failure), and ConnectionRefusedError
and are not caught.

The more generic OSError should be caught here instead.

Resolves #1905
Resolves: https://issues.redhat.com/browse/RHEL-46030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-goode evan-goode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

smtplib: catch OSError, not SMTPException evan-goode/dnf
2 participants
@evan-goode @tuxmika