needs-restarting: Get boot time from systemd UnitsLoadStartTimestamp #560
Conversation
|
Hello @evan-goode! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-10-11 22:41:01 UTC |
148048a to
6391132
Compare
|
@bajertom said:
Marking this as RFR. @ppisar I'll request your review since you investigated the regression last time :) |
|
Manual testing did not find any problem. |
6391132 to
fb8c919
Compare
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
fb8c919 to
17b38c8
Compare
Resolves https://issues.redhat.com/browse/RHEL-35577.
Get the boot time from
UnitsLoadStartTimestampif systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2].Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does.
[1] #527
[2] https://issues.redhat.com/browse/RHEL-39775