pre-compile regex in PriorityDirectoryConverter (NationalSecurityAgen…

…cy#1023)
rpg36 · Jan 7, 2025 · 638b0f4 · 638b0f4
1 parent b60c70e
commit 638b0f4
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/main/java/emissary/command/converter/PriorityDirectoryConverter.java b/src/main/java/emissary/command/converter/PriorityDirectoryConverter.java
@@ -6,19 +6,24 @@
 import org.apache.commons.lang3.StringUtils;
 import picocli.CommandLine.ITypeConverter;
 
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
 public class PriorityDirectoryConverter implements ITypeConverter<PriorityDirectory> {
 
     public PriorityDirectoryConverter() {
         super();
     }
 
     public static final String PRIORITY_DIR_REGEX = ".*:\\d+$";
+    private static final Pattern priorityDirRegex = Pattern.compile(PRIORITY_DIR_REGEX);
 
     @Override
     public PriorityDirectory convert(String value) {
         final String dirName;
         final int priority;
-        if (value.matches(PRIORITY_DIR_REGEX)) {
+        Matcher matcher = priorityDirRegex.matcher(value);
+        if (matcher.matches()) {
             dirName = StringUtils.substringBeforeLast(value, ":");
             priority = Integer.parseInt(StringUtils.substringAfterLast(value, ":"));
         } else {