oauth: refactorize request_access_token() returning a simple boolean #9299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpl
requested changes
Jan 2, 2024
| @@ -707,7 +702,7 @@ public function request_access_token($auth_code, $state = null) | |||
| // store crypted code_verifier because session is going to be killed | |||
| $this->login_phase['code_verifier'] = $_SESSION['oauth_code_verifier']; | |||
| } | |||
| return $this->login_phase; | |||
| return true; | |||
There was a problem hiding this comment.
Let's move the other two return false statements to the end of the function.
c3ba7d8 to
ab12d71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello please find this small refactorization on OAuth module (remove unused parameters) as they are now stored during login_phase