Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "increment_style" CS #9296

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Jan 1, 2024

No description provided.

@alecpl
Copy link
Member

alecpl commented Jan 1, 2024

I don't like it. I know Symfony uses it, but Laravel does not. So, there's no wide consensus. Let's skip this change.

@mvorisek
Copy link
Contributor Author

mvorisek commented Jan 1, 2024

Ok, let's assert the "post" increment style then for now.

@alecpl alecpl merged commit 86eda9f into roundcube:master Jan 1, 2024
15 checks passed
@mvorisek mvorisek deleted the increment_style_cs branch January 1, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants