Add override method attributes #9272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like you to rather focus on fixes first, please. This is more like a feature. |
|
BTW, I'm not a fan of this one. |
f84a51d to
f6757eb
Compare
e6a3c39 to
956e2bf
Compare
956e2bf to
d575074
Compare
|
@alecpl, in #9272 (comment) you have written you are not fan of this change, I have updated the PR description to explain the advantages better. Did it addressed your concerns or do you still have some questions? |
d575074 to
c056afc
Compare
c056afc to
a93a42c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpful to detect removed/renamed parent methods of parent, possibly external, classes.
Generated based on phpstan data.
https://stitcher.io/blog/override-in-php-83 describes the advantages, for more details see https://wiki.php.net/rfc/marking_overriden_methods RFC