Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate set-output #35

Merged
merged 1 commit into from
May 16, 2023
Merged

Deprecate set-output #35

merged 1 commit into from
May 16, 2023

Conversation

noatamir
Copy link
Contributor

I noticed deprecation warning on set-out and followed the documentaiton here: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I'm not sure experienced in solving such issues, so I wasn't sure how to test it, and suggestions on how to proceed would be welcome.

@rossjrw rossjrw added the enhancement New feature or request label Mar 14, 2023
@rossjrw
Copy link
Owner

rossjrw commented Mar 14, 2023

Thank you! Will make sure I take a look at this sometime before May 2023 :P

@oraNod
Copy link

oraNod commented May 9, 2023

@rossjrw Hello. I also noticed the same warning about the deprecated command in a recent PR.

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

FWIW, based on the details in that blog post I think the changes in this PR should be alright. Could you please take a look before the commands are disabled at the end of the month? Thanks.

Copy link

@CMDJojo CMDJojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes look good. It would be great to merge this before June 1st, because if it doesn't get merged until then, the action will fail (according to GitHub docs)

@rossjrw rossjrw changed the title Depreciating set-output Deprecate set-output May 16, 2023
@rossjrw rossjrw merged commit 70d0e7a into rossjrw:main May 16, 2023
@rossjrw
Copy link
Owner

rossjrw commented May 16, 2023

Looks good. Thank you @noatamir! (and thank you @CMDJojo 😛)

Released in v1.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants