Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the zfs-snapshot script support datasets with spaces #12

Merged
merged 1 commit into from
May 24, 2024
Merged

Make the zfs-snapshot script support datasets with spaces #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions etc/periodic/zfs-snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ create_snapshot()
fi

# loop through datasets, do snapshots of each
for dataset in $datasets; do
printf "%s" "${datasets}" | while IFS= read -r dataset; do
snapshot="$dataset@$now"
# look for an existing snapshot with this name
if zfs list $snapshot > /dev/null 2>&1; then
if zfs list "$snapshot" > /dev/null 2>&1; then
echo " snapshot $snapshot already exists, skipping..."
else
echo " taking snapshot: $snapshot"
zfs snapshot $snapshot
zfs snapshot "$snapshot"
fi
done
}
Expand All @@ -55,12 +55,12 @@ delete_snapshot()
{
snapshot=$1
echo " destroying old snapshot, $snapshot"
if ! echo $snapshot | grep -q @; then
if ! printf "%s" "$snapshot" | grep -q @; then
# refuse to destroy something that doesn't look like a snapshot
echo >&2 " aborting: not a snapshot: $snapshot"
exit 1
fi
zfs destroy -r $snapshot
zfs destroy -r "$snapshot"
}

# take a type snapshot of pool, keeping keep old ones
Expand Down Expand Up @@ -110,17 +110,17 @@ do_pool()
# (using sort as zfs's sort seems to have bugs)
snapshots=`zfs list -H -o name -t snapshot | sort | grep $regex`
# count them
count=`echo $snapshots | wc -w`
count=`printf "%s" "$snapshots" | wc -l`
if [ $count -ge 0 ]; then
# how many items should we delete
delete=`expr $count - $keep`
count=0
# walk through the snapshots, deleting them until we've trimmed deleted
for snapshot in $snapshots; do
printf "%s" "${snapshots}" | while IFS= read -r snapshot; do
if [ $count -ge $delete ]; then
break
fi
delete_snapshot $snapshot
delete_snapshot "$snapshot"
count=`expr $count + 1`
done
fi
Expand Down