Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multiple Input files #505

Merged
merged 13 commits into from
Dec 4, 2024
Merged

Add Multiple Input files #505

merged 13 commits into from
Dec 4, 2024

Conversation

AddyMills
Copy link
Contributor

I found myself needing to add files programatically sometimes (where I don't know the amount of inputs beforehand), especially if I were to use a custom amix argument. I wasn't able to figure out how to do this with the current code.

In this PR, I added a new Argument file called MultiInputArgument.cs which takes in an IEnumerable with file paths, checks that all file paths exist, and then add the inputs to the FFMpeg string. If at least one path doesn't exist, it throws an error message that shows the files that don't exist/can't be accessed.

I also added a test for MultiInputArguments that passes.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (f8407bc) to head (69535d6).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
FFMpegCore/FFMpeg/Arguments/MultiInputArgument.cs 88.00% 3 Missing ⚠️
FFMpegCore/FFMpeg/FFMpegArguments.cs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #505      +/-   ##
==========================================
- Coverage   74.31%   71.54%   -2.78%     
==========================================
  Files         113      116       +3     
  Lines        2854     2959     +105     
  Branches        0      282     +282     
==========================================
- Hits         2121     2117       -4     
- Misses        733      737       +4     
- Partials        0      105     +105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rosenbjerg rosenbjerg merged commit 71e3684 into rosenbjerg:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants