-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression test for FastCDR typesupport. #266
Conversation
@mikaelarguedas I don't know if this is the right place for this to live. It's really only testing FastCDR typesupport, but it also depends on rcl_interfaces and rclcpp. |
LocationAs this is a very specific test:
Then the right place to land it will depend on how many dependencies we can get rid of. I'm fine leaving it here for now (in this repository but as in a new package to clarify dependencies and be able to move it somewhere else easily). The dependency on I'm surprised we need I'm not sure it's worth adding a test for this as we already had ~60 tests failing because of this. But having more specific tests to pin the exact issue is always valuable. What to testWere you able to reproduce the issue with a simple message type support (redo of this comment ros2/rclcpp#464 (comment))? as the bug seems to be a generic typesupport issue I would expect that to be the case. I would expect that you can reproduce the same failure by pacssin an unbounded array with strings around. This will confirm that we already have messages in Then the question is: "as we already had ~60 tests failing because of this particular issue, do we need to add such test to the suite?". I think that's good to have a simplistic test to pin down the issue, on the other hand if this is only to ctch regressions, we will catch regression with our current test suite. |
77b97c3
to
63f0544
Compare
I would be good with dropping the test entirely, this is essentially what I needed to completely isolate the issue, but probably doesn't have enough coverage to justify standing on it's own. |
Also, with another look, it doesn't look like it actually depends on rclcpp, that was leftover from my exploration. |
I'm going to close this, I don't think it makes sense to add as a test, it's moreso just a reference. |
Adds a regression test for the the bug we saw in Bionic with FastRTPS.
Connects to: ros2/rclcpp#464