Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rviz_rendering] Scale rendering window correctly on Windows #23

Merged

Conversation

greimela-si
Copy link
Contributor

Adding the "left" and "top" parameter positions the render window correctly inside the QWindow.

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I want to try it on Linux to make sure we don't need to special case this for Windows only.

I should be able to merge after checking that. Thanks!

@wjwwood wjwwood added enhancement New feature or request in review Waiting for review (Kanban column) labels Sep 8, 2017
@wjwwood
Copy link
Member

wjwwood commented Sep 8, 2017

I think Linux was confirmed offline, feel free to comment here if that's not the case.

@wjwwood wjwwood merged commit d060a58 into ros2:ros2 Sep 8, 2017
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Sep 8, 2017
@anhosi anhosi deleted the bugfix/scale_rendering_window_on_windows branch November 15, 2017 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants