setup minimal viable rviz2 application #20
Conversation
76160b6 to
1f6d674
Compare
|
rebased |
| @@ -237,7 +237,7 @@ void DisplayGroup::update( float wall_dt, float ros_dt ) | |||
| Display* display = displays_.at( i ); | |||
| if( display->isEnabled() ) | |||
| { | |||
| display->update( wall_dt, ros_dt ); | |||
| display-rviz>update( wall_dt, ros_dt ); | |||
There was a problem hiding this comment.
Man, I was so confused when I got here in my own refactoring 😄.
aa378b9 to
fa7ac92
Compare
|
Ok, I've rebased this into two commits (one moving files and the other all the other changes). I'll try to come up with a list of pointers to make the review easier after lunch. |
|
Some notes for reviewers: What I'd like out of a review:
Other things:
While the reviews are happening (I hope to merge this tomorrow) I will be auditing the code to make issues for as many of the |
|
Also, this pr requires ros2/rclcpp#375 which was merged after beta-3, so if you want to test this you'll need the latest from the ros2 repositories. |
|
Oh, and for those that didn't see it, this is what could be rendered with this branch if you had the right setup and associated programs running: https://gfycat.com/formaldownrightindigowingedparrot I won't take the time to describe that setup, since it was so fragile. A better (easier to setup) demo is forthcoming. |
| : size(0) | ||
| {} | ||
|
|
||
| std::shared_ptr<uint8_t> data; |
There was a problem hiding this comment.
Import <memory> when using std::shared_ptr.
There was a problem hiding this comment.
I'll add it, but this file (since it is in the temp folder) will probably be deleted in the future.
There was a problem hiding this comment.
I know, but the error would persist if the file is moved instead.
fa7ac92 to
5dbedb7
Compare
The idea here is to get something that compiles, runs, and initializes the render system. I'm commenting out anything remotely difficult to deal with (location of resources, non-trivial uses of ROS 1, etc...) to just get it working.
This should give us a better skeleton to work off of and make improvements to.
This is still a work in progress, opening for visibility so I can sync with my other machine easily.
I've been aggressively adding
TODO(wjwwood): ...comments throughout as I go, so I can convert those to issues after I have the application running at least.