Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting for rviz_rendering #17

Merged
merged 5 commits into from
Sep 2, 2017
Merged

Linting for rviz_rendering #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b5caa6b
Introduce linters in rviz_rendering
Martin-Idel-SI Aug 29, 2017
89b9b74
Fix cppcheck errors
Martin-Idel-SI Aug 29, 2017
bfcdc73
Extract SdkQtCameraMan from OgreBites to fix linters
Martin-Idel-SI Aug 29, 2017
12ca19b
adding a todo about the copyright linter
wjwwood Sep 2, 2017
e30ea54
add a comment about delete-less new call
wjwwood Sep 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions rviz_rendering/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,16 @@ endif()

install(TARGETS rendering_example DESTINATION bin)

if(BUILD_TESTING)
# TODO(wjwwood): replace this with ament_lint_auto() and/or add the copyright linter back
find_package(ament_cmake_cppcheck REQUIRED)
find_package(ament_cmake_cpplint REQUIRED)
find_package(ament_cmake_lint_cmake REQUIRED)
find_package(ament_cmake_uncrustify REQUIRED)
ament_cppcheck()
ament_cpplint()
ament_lint_cmake()
ament_uncrustify()
endif()

ament_package()
5 changes: 5 additions & 0 deletions rviz_rendering/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@
<build_depend>rviz_ogre_vendor</build_depend>
<build_depend>qtbase5-dev</build_depend>

<test_depend>ament_cppcheck</test_depend>
<test_depend>ament_cpplint</test_depend>
<test_depend>ament_cmake</test_depend>
<test_depend>ament_uncrustify</test_depend>

<exec_depend>assimp</exec_depend>
<exec_depend>libogre</exec_depend>
<exec_depend>libqt5-core</exec_depend>
Expand Down
366 changes: 0 additions & 366 deletions rviz_rendering/src/SdkQtCameraMan.h
View file
Open in desktop

This file was deleted.

Loading